Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sim-swap-subscriptions]: Remove allOf for sinkCredential in SubscriptionRequest #174

Open
dfischer-tech opened this issue Nov 19, 2024 · 0 comments · May be fixed by #175
Open

[sim-swap-subscriptions]: Remove allOf for sinkCredential in SubscriptionRequest #174

dfischer-tech opened this issue Nov 19, 2024 · 0 comments · May be fixed by #175

Comments

@dfischer-tech
Copy link

Problem description
Currently, the sinkCredential has a not needed allOf here in the request.
The code-generator it will produce unexpected behaviours having the description inside the allOf

        sinkCredential:
          allOf:
            - description: A sink credential provides authentication or authorization information necessary to enable delivery of events to a target.
            - $ref: "#/components/schemas/SinkCredential"

Expected behavior
Remove the allOf and move the description to the SinkCredential-component

        sinkCredential:
            - $ref: "#/components/schemas/SinkCredential"
<....>

    SinkCredential:
      description: A sink credential provides authentication or authorization information necessary to enable delivery of events to a target.
      type: object
      properties:
        credentialType:
          type: string
          enum:
            - PLAIN
            - ACCESSTOKEN
            - REFRESHTOKEN
          description: "The type of the credential."
      discriminator:
        propertyName: credentialType
        mapping:
          PLAIN: "#/components/schemas/PlainCredential"
          ACCESSTOKEN: "#/components/schemas/AccessTokenCredential"
          REFRESHTOKEN: "#/components/schemas/RefreshTokenCredential"
      required:
        - credentialType
@dfischer-tech dfischer-tech changed the title [sim-swap-subscriptions]: Remove "allOf" for sinkCredential in SubscriptionRequest [sim-swap-subscriptions]: Remove allOf for sinkCredential in SubscriptionRequest Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant