Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: standardize errors to track with commonalities #30

Merged

Conversation

caubut-charter
Copy link
Contributor

@caubut-charter caubut-charter commented Oct 18, 2024

What type of PR is this?

bug

What this PR does / why we need it:

Errors are currently not in alignment with Commonalities.

Which issue(s) this PR fixes:

Fixes #29

Special notes for reviewers:

Changelog input

fix: Updates error responses to align with Commonalities.

Additional documentation

@caubut-charter caubut-charter self-assigned this Oct 18, 2024
@caubut-charter caubut-charter linked an issue Oct 18, 2024 that may be closed by this pull request
4 tasks
Copy link

linux-foundation-easycla bot commented Oct 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

github-actions bot commented Oct 18, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 1 0 3.29s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.76s
✅ YAML yamllint 1 0 0.69s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@caubut-charter caubut-charter force-pushed the 29-fix-standardize-errors-to-track-with-commonalities branch 2 times, most recently from 3064f4f to 7c65226 Compare November 1, 2024 01:28
@caubut-charter caubut-charter force-pushed the 29-fix-standardize-errors-to-track-with-commonalities branch from 7c65226 to 6b15206 Compare November 1, 2024 01:30
@caubut-charter caubut-charter marked this pull request as ready for review November 1, 2024 01:32
@RandyLevensalor
Copy link
Contributor

@caubut-charter Are all of the methods that have a 501 message optional for this API?

If the method is required, I'm not sure we want to support the 501 error on those.

@caubut-charter
Copy link
Contributor Author

@caubut-charter Are all of the methods that have a 501 message optional for this API?

If the method is required, I'm not sure we want to support the 501 error on those.

@RandyLevensalor removed the 501 from minimal set of endpoints which is isolated-networks with the default device so no service sites or devices related endpoints.

Copy link
Contributor

@RandyLevensalor RandyLevensalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caubut-charter caubut-charter merged commit d668ea4 into main Nov 15, 2024
2 checks passed
@caubut-charter caubut-charter deleted the 29-fix-standardize-errors-to-track-with-commonalities branch November 15, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Standardize errors to track with Commonalities
2 participants