-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: standardize errors to track with commonalities #30
fix: standardize errors to track with commonalities #30
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
3064f4f
to
7c65226
Compare
7c65226
to
6b15206
Compare
@caubut-charter Are all of the methods that have a 501 message optional for this API? If the method is required, I'm not sure we want to support the 501 error on those. |
@RandyLevensalor removed the 501 from minimal set of endpoints which is isolated-networks with the default device so no service sites or devices related endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
bug
What this PR does / why we need it:
Errors are currently not in alignment with Commonalities.
Which issue(s) this PR fixes:
Fixes #29
Special notes for reviewers:
Changelog input
Additional documentation