Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAM API: add get clusters api #318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gainsley
Copy link
Collaborator

@gainsley gainsley commented Nov 6, 2024

What type of PR is this?

  • enhancement/feature

What this PR does / why we need it:

Addresses a comment in #280 regarding the addition of the KubernetesClusterRef, and how users would expect to find it. While the KubernetesClusterRef can be found in the AppInstanceInfo, there may be clusters present without any AppInstances. The only way to see those clusters is via a cluster API to list the clusters.

Which issue(s) this PR fixes:

Special notes for reviewers:

Changelog input

 release-note
- add clusters list API

Additional documentation

responses:
'200':
description: |
Successful response, returning the clusters.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose returning the clusters information?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gunjald I have updated this, please take a look. thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants