Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the example for sub - initialEvent and error MULTIEVENT_SUBSCRIPTION_NOT_SUPPORTED and some typos. #267

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

dfischer-tech
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Correct the example and some typos.

Which issue(s) this PR fixes:

Fixes #266

maxl2287
maxl2287 previously approved these changes Oct 15, 2024
Copy link
Contributor

@maxl2287 maxl2287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @dfischer-tech! 🚀

jlurien
jlurien previously approved these changes Oct 24, 2024
@jlurien jlurien self-requested a review October 24, 2024 16:21
@jlurien
Copy link
Collaborator

jlurien commented Oct 24, 2024

Before merging this in main we have to set versions to wip @maxl2287 @bigludo7 I'm ok with the rest of content.

bigludo7
bigludo7 previously approved these changes Oct 24, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxl2287 maxl2287 dismissed stale reviews from bigludo7 and jlurien via d1d8b14 October 25, 2024 08:28
@maxl2287 maxl2287 requested review from bigludo7 and maxl2287 October 25, 2024 08:29
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maxl2287
Line 86 should have wip as version as well no?

@jlurien
Copy link
Collaborator

jlurien commented Nov 18, 2024

Hi @maxl2287 Line 86 should have wip as version as well no?

Yes, please @dfischer-tech could you change it to:

  • url: "{apiRoot}/geofencing-subscriptions/vwip"

@maxl2287
Copy link
Contributor

@jlurien - I did it now for @dfischer-tech.
Can be now approved from my side.

@maxl2287 maxl2287 requested a review from bigludo7 November 18, 2024 21:48
Copy link
Contributor

@maxl2287 maxl2287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlurien jlurien merged commit bc27289 into camaraproject:main Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[geofencing-subscriptions]: MultieventSubscriptionNotSupported instead of PermissionDenied.
4 participants