Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align device object with Guidelines Issue #228 #237

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

jlurien
Copy link
Collaborator

@jlurien jlurien commented Jul 25, 2024

What type of PR is this?

  • enhancement/feature

What this PR does / why we need it:

Adopt Commonalities recommendations regarding usage of device

Which issue(s) this PR fixes:

Fixes #228

Special notes for reviewers:

We have to update test plans later with some new scenario

Changelog input

 device made optional in request body with indications

@jlurien jlurien requested a review from bigludo7 as a code owner July 25, 2024 12:33
@jlurien jlurien requested a review from maxl2287 July 25, 2024 12:33
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 3 0 4.75s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.82s
✅ YAML yamllint 3 0 0.64s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlurien jlurien merged commit 6a1afdc into main Jul 25, 2024
1 check passed
@jlurien
Copy link
Collaborator Author

jlurien commented Jul 25, 2024

Merging quickly so we can add this necessary changes to the RC. We can make further reviews in the PRs for RC or during the RC bugfixing process (M3 to M4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align device object with Guidelines
2 participants