-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Readiness checklist for Geofencing-Subscriptions #234
Add Readiness checklist for Geofencing-Subscriptions #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This morning my understanding is we skip 0.2 for geofencing & location-retrieval to avoid confusion with previous release that was the 0.2 at family level.
So I expect here v0.3.
documentation/API_documentation/geofencing-subscriptions-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
documentation/API_documentation/geofencing-subscriptions-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/geofencing-subscriptions-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would just recommend to use relativ links to stay in the release.
And I assume the final updates will be done in the release PR for the repository, including line 3, which might finally look like:
Checklist for geofencing-subscriptions v0.3.0-rc.1 in r1.1
…eadiness-Checklist.md Co-authored-by: Herbert Damker <[email protected]>
…eadiness-Checklist.md Co-authored-by: Herbert Damker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the hint, I was confused about what to fill in the placeholders "api-version in ...". @bigludo7 we will have to align as well the other 2 checklists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Add Readiness checklist for geofencing-subscriptions