Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Readiness checklist for Geofencing-Subscriptions #234

Conversation

maxl2287
Copy link
Contributor

@maxl2287 maxl2287 commented Jul 23, 2024

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Add Readiness checklist for geofencing-subscriptions

@maxl2287 maxl2287 self-assigned this Jul 23, 2024
@maxl2287 maxl2287 added the subproject management Indicating issues with subproject repository or release management process label Jul 23, 2024
@maxl2287 maxl2287 changed the title Feature/add api readiness checklist geofencing Add Readiness checklist for Geofencing-Subscriptions Jul 23, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This morning my understanding is we skip 0.2 for geofencing & location-retrieval to avoid confusion with previous release that was the 0.2 at family level.
So I expect here v0.3.

bigludo7
bigludo7 previously approved these changes Jul 23, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hdamker
hdamker previously approved these changes Jul 23, 2024
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would just recommend to use relativ links to stay in the release.

And I assume the final updates will be done in the release PR for the repository, including line 3, which might finally look like:
Checklist for geofencing-subscriptions v0.3.0-rc.1 in r1.1

@maxl2287 maxl2287 dismissed stale reviews from hdamker and bigludo7 via f18a6cc July 23, 2024 20:13
@maxl2287 maxl2287 requested review from bigludo7 and hdamker July 23, 2024 20:14
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlurien
Copy link
Collaborator

jlurien commented Jul 25, 2024

LGTM, would just recommend to use relativ links to stay in the release.

And I assume the final updates will be done in the release PR for the repository, including line 3, which might finally look like: Checklist for geofencing-subscriptions v0.3.0-rc.1 in r1.1

Thanks for the hint, I was confused about what to fill in the placeholders "api-version in ...". @bigludo7 we will have to align as well the other 2 checklists

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlurien jlurien merged commit 38a001a into camaraproject:main Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subproject management Indicating issues with subproject repository or release management process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants