Update maxAge-behaviour for /verify & /retrieve
#218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxl2287
force-pushed
the
feature/update-max-age-behaviour
branch
from
6b6f79e to
874d57a
Compare
mhfoo
reviewed
Jun 24, 2024
|
@camaraproject/device-location_maintainers this PR is ready to be reviewed 😸 |
bigludo7
previously approved these changes
Jul 11, 2024
jlurien
reviewed
Jul 15, 2024
jlurien
requested changes
Jul 23, 2024
|
@maxl2287 please give priority to this PR as it is blocking the process for these 2 APIs. Thanks |
Co-authored-by: Jose Luis Urien <[email protected]>
…e/update-max-age-behaviour # Conflicts: # code/API_definitions/location-retrieval.yaml # code/API_definitions/location-verification.yaml
bigludo7
reviewed
Jul 24, 2024
There was a problem hiding this comment.
Hello @maxl2287
Sorry if I miss something but I do not understand why you removed all 422 codes
For me we have to keep these:
GENERIC_422_UNPROCESSABLE_ENTITY:
summary: Unprocessable entity
description: The request was well-formed but was unable to be processed due to semantic errors or not applicable values. This is the generic error code for 422 responses.
value:
status: 422
code: UNPROCESSABLE_ENTITY
message: "Value not acceptable: ..."
GENERIC_422_DEVICE_NOT_APPLICABLE:
summary: Service not applicable to the device
description: The provided device is not compatible with the requested operation, according to the service provider rules.
value:
status: 422
code: DEVICE_NOT_APPLICABLE
message: "The device is not applicable for the requested operation"
GENERIC_422_DEVICE_IDENTIFIERS_MISMATCH:
summary: Device identifiers mismatch
description: Several device identifiers are provided but do not match the same device
value:
status: 422
code: DEVICE_IDENTIFIERS_MISMATCH
message: "The provided device identifiers do not match the same device"
GENERIC_422_UNSUPPORTED_DEVICE_IDENTIFIERS:
summary: None of the provided device identifiers is supported by the implementation
description: Message may list the supported device identifiers
value:
status: 422
code: UNSUPPORTED_DEVICE_IDENTIFIERS
message: "Supported device supported are: ..."
GENERIC_422_UNIDENTIFIABLE_DEVICE:
summary: No identifier provided
description: No device identifier provided for the device to be located
value:
status: 422
code: UNIDENTIFIABLE_DEVICE
message: "A device must be provided"
|
We have to add another example to the examples array, e.g.: |
jlurien
reviewed
Jul 24, 2024
jlurien
approved these changes
Jul 24, 2024
|
@bigludo7 take a final look and we can merge it. Thanks |
bigludo7
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Updating the
maxAge-behaviour for location-verification and location-retrievalWhich issue(s) this PR fixes:
Fixes #216