Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update base-path & security-scope for geofencing-subscriptions #191

Conversation

maxl2287
Copy link
Contributor

@maxl2287 maxl2287 commented May 7, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Allignment on camaraproject/Commonalities#177.

  • Rename to geofencing-subscriptions.yaml
  • Rename basepath to /geofencing-subscriptions/v0
  • update securityscope

Which issue(s) this PR fixes:

Fixes #190
Fixes #193

@maxl2287 maxl2287 requested review from bigludo7 and jlurien as code owners May 7, 2024 08:41
@maxl2287 maxl2287 marked this pull request as draft May 7, 2024 09:04
@maxl2287 maxl2287 marked this pull request as ready for review May 7, 2024 09:24
bigludo7
bigludo7 previously approved these changes May 7, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I guess we do not have yet to change the home page readme file.

@maxl2287 maxl2287 changed the title feat: update base-path for geofencing to geofencing-subscriptions update base-path & security-scope for geofencing-subscriptions May 7, 2024
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, look into my comments to the issue about changing API title and possibly the event names as well

@jlurien jlurien requested a review from bigludo7 May 21, 2024 07:29
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM/

@bigludo7 bigludo7 merged commit d1d6e02 into camaraproject:main Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants