-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update base-path & security-scope for geofencing-subscriptions #191
update base-path & security-scope for geofencing-subscriptions #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I guess we do not have yet to change the home page readme file.
geofencing-subscriptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, look into my comments to the issue about changing API title and possibly the event names as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM/
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Allignment on camaraproject/Commonalities#177.
geofencing-subscriptions.yaml
/geofencing-subscriptions/v0
Which issue(s) this PR fixes:
Fixes #190
Fixes #193