Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error alignments for Event Notifications Artifact #351

Conversation

PedroDiez
Copy link
Collaborator

@PedroDiez PedroDiez commented Dec 3, 2024

What type of PR is this?

  • correction

What this PR does / why we need it:

This PR provides an aligment for CAMARA event notifications artifact in terms of documented errors and also API Design guidelines for mandatory errors for this artifact.

Rational is detailed in #348

Mandatory/Documented errors are proposed to be: 400, 401, 403, 410, 429. Documents impacted:

Which issue(s) this PR fixes:

Fixes #348

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

Changelog input

Error alignments for Event Notifications Artifact in MetaRelease Spring 25

Additional documentation

N/A

Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych merged commit 336d0b5 into camaraproject:main Dec 5, 2024
1 check passed
rartych added a commit to rartych/Commonalities that referenced this pull request Dec 5, 2024
Fixed typos and suggestions
Added camaraproject#351
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction correction in documentation Spring25
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors Documented in notification-as-cloud-event.yaml
4 participants