Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Pedro Díez García <[email protected]>
  • Loading branch information
rartych and PedroDiez authored Dec 5, 2024
1 parent acfbc56 commit 3ad4b95
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ This release contains documents and artifacts of Commonalities version 0.5.0-alp

### Changed
* Normalization of error status and code allowed values using `enum` by @PedroDiez in https://github.com/camaraproject/Commonalities/pull/316
* Guidelines for subscription and event notification in API Design Guideliness by @bigludo7 in https://github.com/camaraproject/Commonalities/pull/313 main changes:
* Guidelines for subscription and event notification in API Design Guidelines by @bigludo7 in https://github.com/camaraproject/Commonalities/pull/313 main changes:
- updated `terminationReason` in event notification type "subscription-ends"
- updated description of `sink` and `sinkCredential` attributes for subscription
- added rules for subscriptions with device identifier attribute
- added section 11.7 Resource access restriction relevant to subscriptions
- added clarification on `expiresAt` attribute for subscription
* Updated error codes and changed `info.description` template for device / phone number identifiers in Appendix A in API Design Guideliness by @eric-murray in https://github.com/camaraproject/Commonalities/pull/324 and https://github.com/camaraproject/Commonalities/pull/346
* Guidelines regarding mandatory error `status` and alignment of error codes related to identifiers in API Design Guideliness by @PedroDiez in https://github.com/camaraproject/Commonalities/pull/329 and https://github.com/camaraproject/Commonalities/pull/351
* Guidelines regarding mandatory error `status` and alignment of error codes related to identifiers in API Design Guidelines by @PedroDiez in https://github.com/camaraproject/Commonalities/pull/329 and https://github.com/camaraproject/Commonalities/pull/351

### Fixed
* Clarification on api-name, filenames and servers object by @rartych in https://github.com/camaraproject/Commonalities/pull/333
Expand Down

0 comments on commit 3ad4b95

Please sign in to comment.