eDSL, docs: new eDSL example showing the usage of guards, and a correction in syntax in docs #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be |
|
Great, changed the docs too. |
anshumanmohan
changed the title
ethanuppal
added a commit
that referenced
this pull request
Jun 15, 2024
* eDSL, docs: new eDSL example showing the usage of guards, and a correction in syntax in docs (#2133) * Get the builder to generate ops between ports * Small example showing various forms of guards * Tweak & and | docs for guards * No more guard conjunction to declare group `done` signals (#2131) * One less guard disjunct in gen_exp * No guard conj in sdn.py * No more & in ntt * No more guard conj in tuple * No more group conj in gen_exp * Stray expect file * Prefer `seq_mem`s to `comb_mem`s all over (#2127) * Port Python code to seq mems * Update expect files to deal with new seq mems * Fix gen_exp to use seq mems * Catch up expect files to seq mems * Trigger Build * Silly mistake * Expect files chasing after silly mistake * Preprocessor mockup * Integrate preprocessor with LSP --------- Co-authored-by: Anshuman Mohan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes a little example showing how to generate the various kinds of guards using the eDSL.
This is not yet documented; I will leave that to @KabirSamsi in a separate PR. When you do document it, please point to my little example!
@rachitnigam I want to flag something. The docs say that conjunction looks like
foo && barand disjunction likefoo || bar. However, in reality you'd get an error like:Is the doc wrong? Am I using it incorrectly? FWIW the eDSL generates single
&and single|and therefore works.