-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation instructions fix: Make runt.toml expect runt version 0.4.1 instead of 0.4.0. #1698
Conversation
The tests seem to be failing with this change. Maybe we need to update the GitHub workflow files to install a newer version of runt? |
Strange. The docker file installs runt using Would a new image need to be pushed to ghcr? I remember in the past that was done manually by you @rachitnigam. |
A new version of the codebase has been released which means that the docker container |
…ting Started' issue
Calyx Docker container 0.6.0 does not have git initialized in /home/calyx
bc597a7
to
619d4ab
Compare
To get polybench working will need to merge this calyx-evaluation PR Also note that docker image 0.6.0 does not have git intialized in /home/calyx. For compiler tests, I'm getting cocotb runt errors. Which also seem to be happening on master? Even on 0.4.0. Not sure if those are expected to fail due to some other work? |
The tests on |
Failing compiler tests seem to be coming from stale Edit: Removing those stale files within the workflow manually worked, but not sure if it is ideal to have those commands left in the workflow explicitly, as opposed to fixing up the docker image. |
What a mess! Do we know why these files exist in the I also mentioned in #1714 (comment) that it seems to me like lots of this headache arises from our current CI approach, which ends up with two different versions of Calyx co-existing and potentially confusing each other. Sticking to just one (either just from the container, or just from git) could help make this stuff less surprising. |
Let's try this again after #1824 |
Fixes issue when following 'Getting Started' requiring a manual version change in runt.toml. Could also be addressed in runt itself, but this is a bandaid fix for now.