Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial tests #2

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Initial tests #2

wants to merge 18 commits into from

Conversation

scardine
Copy link

Just a draft.

scardine and others added 18 commits August 22, 2013 18:17
@scardine
skeleton for testing
18daaa9
@scardine
Create test.py
2c47bd6
@scardine
Module constants in Python traditionally are all uppercase.
fdca5f3
@scardine
function names use underscore_names, not camelCase like in JS.
3b2bf07
@scardine
converted JS style "params" object to Python named parameters
c92ea5b
@scardine
some cleanups, id renamed to id_ (shadows a builtin)
dbe6f59
@scardine
changed is_point() to duck-type, removed ";" line endings.
e5688ca
@scardine
simplified lines_equal
39c4a3a
@scardine
renamed makeKs to make_ks
2ca5fdc
@scardine
Reformat per PEP-8
197f2ca
@scardine
Reformat per PEP-8
09acd78
@scardine
Passing test: result should have the same keys compared to reference.
8da55f9
@scardine
Tests for the "transform" element.
3485890
@scardine
Add IDE files to .gitignore
d1036e8
@scardine
reformat PEP-8
995bff6
@scardine
"if dict.has_key(key):" deprecated - use "if key in dict:"
39939ba
@scardine
* Porting tests from the original
082800b 
* Some refactoring at coordinatesystems.py, coordinate systems are objects now instead
   of dicts
@scardine
code escape around __init__.py
a8dbfe7
@calvinmetcalf
Copy link
Owner

This looks really great thanks you. I made some notes on lines with some small issues, the only major one is the conversion module which needs to be able to take a topojson dict, dict of topojson dicts, topojson file path or object and if it's a path grab the name of the topojson file, we can clean up the topology function to only accept a dict of topojson dicts so it wouldn't need a out_name parameter.

@calvinmetcalf
Copy link
Owner

you should try if possible to do a bunch of little thing instead of one big thing, this also helps us trouble shoot

@scardine
Copy link
Author

I will do that, thanks.

@Casyfill
Copy link
Collaborator

Hey @scardine, I am going to setup CircleCI or Travis Integration soon, then will start adding your tests, step by step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scardine @calvinmetcalf @Casyfill