Adding support for ClickHouse specific lagInFrame function in tests #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue this PR Addresses/Closes
Closes #324
Summary of Changes
New utility macro lag was added to support ClickHouse specific lagInFrame function and to ensure support for all other sql dialects while keeping the test code clean and readable. This macro is used in the 3 tests which use lag function to ensure ClickHouse compatibility
Why Do We Need These Changes
It's needed to add support for ClickHouse in the current 3 tests which use the lag function and any future tests which will use lag function.
Reviewers
@clausherther