This repository has been archived by the owner on Nov 30, 2018. It is now read-only.
WIP: Add replace action to navigation and make navigation type more generic #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making navigation type more generic
navigation
is now derived from the parametric typecommonNavigation('a)
so we can sure for instance the same header component across different StackNavigators.navigation.replace(Config.route)
I moved around a couple of things to accommodate the replace action.
Mainly they were
didUpdate
to inside the reducer so the side effect is more explicit/directRemoveStaleScreen
(ReArray.remove, because of spliceInPlace, does not work with 0 indexes).Missing
Add to the documentation
Let me know if I can improve anything else before merging