Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action with support for commit/tag push workflow trigger #232

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

rgryta
Copy link
Contributor

@rgryta rgryta commented Aug 29, 2024

I'd like to somehow contribute to the project considering that I'm pretty much using this package on daily basis. As such I think it would be nice to add a native CI/CD support for GHA.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.94%. Comparing base (b6773ac) to head (e3ff9a1).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files          26       26           
  Lines        1702     1702           
  Branches      330      330           
=======================================
  Hits         1599     1599           
  Misses         75       75           
  Partials       28       28           
Flag Coverage Δ
python-3.10 93.94% <ø> (ø)
python-3.11 93.94% <ø> (ø)
python-3.8 93.86% <ø> (ø)
python-3.9 93.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rgryta
Copy link
Contributor Author

rgryta commented Aug 29, 2024

One design decision that I've made with this is that I have not migrated any flags from the CLI to be GHA parameters - all of them (except for args) are connected to their own environment variables, so it's already possible to do so using those. See example in README.md.

@rgryta rgryta marked this pull request as ready for review August 29, 2024 13:48
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@coordt
Copy link
Member

coordt commented Aug 29, 2024

@rgryta Thank you for your contribution! I added a few comments and thoughts.

@coordt coordt merged commit e440895 into callowayproject:master Sep 2, 2024
11 of 15 checks passed
@rgryta rgryta deleted the action3 branch September 2, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants