Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed empty string replacement bug #119

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

coordt
Copy link
Member

@coordt coordt commented Jan 6, 2024

Only a missing replacement value will trigger one of the fallback options.

Fixes #117

Only a missing replacement value will trigger one of the fallback options.

Fixes #117
Copy link

github-actions bot commented Jan 6, 2024

Version hint: patch
Current version: 0.16.0
New version (when merged): 0.16.1

Comment ID: Display the version hint-auto-generated

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8db9552) 92.90% compared to head (d9965ab) 92.84%.
Report is 2 commits behind head on master.

Files Patch % Lines
bumpversion/files.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   92.90%   92.84%   -0.07%     
==========================================
  Files          19       19              
  Lines        1255     1257       +2     
  Branches      259      260       +1     
==========================================
+ Hits         1166     1167       +1     
  Misses         60       60              
- Partials       29       30       +1     
Flag Coverage Δ
python-3.10 92.84% <66.66%> (-0.07%) ⬇️
python-3.11 92.84% <66.66%> (-0.07%) ⬇️
python-3.8 92.84% <66.66%> (-0.07%) ⬇️
python-3.9 92.84% <66.66%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coordt coordt merged commit 7164dfc into master Jan 6, 2024
11 of 13 checks passed
@coordt coordt deleted the 117-allow-empty-string-replacement branch January 6, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty string replacement (--replace "") is interpreted as absence of parameter
1 participant