Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version refactor #112

Merged
merged 13 commits into from
Jan 27, 2024
Merged

Version refactor #112

merged 13 commits into from
Jan 27, 2024

Conversation

coordt
Copy link
Member

@coordt coordt commented Dec 26, 2023

A backwards-compatible refactor for dealing with version parsing, incrementing, and serializing

- Turns None into an empty string
- created a "conventions" module for future release
- added an optional `depends_on` version component configuration
- The `depends_on` is required for PEP440 versioning
- Moved serialization from VersionConfig to version.serialization
Copy link

github-actions bot commented Dec 26, 2023

Version hint: patch
Current version: 0.17.1
New version (when merged): 0.17.2

Comment ID: Display the version hint-auto-generated

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (10e5d7d) 92.83% compared to head (8bfa5d9) 93.40%.
Report is 2 commits behind head on master.

Files Patch % Lines
bumpversion/versioning/models.py 95.68% 2 Missing and 3 partials ⚠️
bumpversion/config/models.py 50.00% 3 Missing ⚠️
bumpversion/version_part.py 90.90% 0 Missing and 1 partial ⚠️
bumpversion/versioning/conventions.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   92.83%   93.40%   +0.57%     
==========================================
  Files          21       24       +3     
  Lines        1409     1486      +77     
  Branches      294      297       +3     
==========================================
+ Hits         1308     1388      +80     
+ Misses         70       68       -2     
+ Partials       31       30       -1     
Flag Coverage Δ
python-3.10 93.40% <95.70%> (+0.57%) ⬆️
python-3.11 93.40% <95.70%> (+0.57%) ⬆️
python-3.8 93.40% <95.70%> (+0.57%) ⬆️
python-3.9 93.40% <95.70%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coordt coordt merged commit 4439fd2 into master Jan 27, 2024
13 checks passed
@coordt coordt deleted the version-refactor branch January 27, 2024 14:57
@reindlt reindlt mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant