Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored configuration file updating. #101

Merged

Conversation

coordt
Copy link
Member

@coordt coordt commented Dec 6, 2023

TOML files are parsed, specific values are updated, and re-written to avoid updating the wrong data.

It uses a two-way parser, so all formatting and comments are maintained.

INI-type configuration files use the old way since that format is deprecated.

Fixes #93

- Also made all attributes required except `filename`, `glob`, and `key_path`
TOML files are parsed, specific values are updated, and re-written to avoid updating the wrong data.

It uses a two-way parser, so all formatting and comments are maintained.

INI-type configuration files use the old way, since that format is deprecated.
@coordt coordt linked an issue Dec 6, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (51526bf) 93.59% compared to head (8188a42) 91.71%.

❗ Current head 8188a42 differs from pull request most recent head cae12dc. Consider uploading reports for the commit cae12dc to get more accurate results

Files Patch % Lines
bumpversion/files.py 77.64% 14 Missing and 5 partials ⚠️
bumpversion/config/files.py 81.11% 11 Missing and 6 partials ⚠️
bumpversion/config/models.py 92.64% 3 Missing and 2 partials ⚠️
bumpversion/config/__init__.py 88.57% 2 Missing and 2 partials ⚠️
bumpversion/bump.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #101      +/-   ##
==========================================
- Coverage   93.59%   91.71%   -1.89%     
==========================================
  Files          15       18       +3     
  Lines        1078     1159      +81     
  Branches      169      175       +6     
==========================================
+ Hits         1009     1063      +54     
- Misses         46       66      +20     
- Partials       23       30       +7     
Flag Coverage Δ
python-3.10 92.33% <87.93%> (-1.27%) ⬇️
python-3.8 91.71% <85.40%> (-1.89%) ⬇️
python-3.9 91.71% <85.40%> (-1.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coordt coordt changed the base branch from master to next December 6, 2023 13:22
@coordt coordt merged commit ca75de5 into next Dec 6, 2023
1 check passed
@coordt coordt deleted the 93-incorrectly-bumps-dependency-that-matches-project-version branch December 6, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] incorrectly bumps dependency that matches <project version>
1 participant