Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update area units and available_area description. #705

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

brynpickering
Copy link
Member

Fixes #701

Summary of changes in this pull request

Reviewer checklist

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (6b60eb7) to head (a61fdd2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #705   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          29       29           
  Lines        4060     4060           
  Branches      580      580           
=======================================
  Hits         3897     3897           
  Misses         72       72           
  Partials       91       91           

@brynpickering
Copy link
Member Author

@sstroemer any chance you can confirm this is a fix to the issue you raised?

sstroemer
sstroemer previously approved these changes Nov 29, 2024
Copy link
Contributor

@sstroemer sstroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this, thanks for the ping. Looks good!

@brynpickering brynpickering merged commit f2e4f43 into main Nov 29, 2024
9 of 11 checks passed
@brynpickering brynpickering deleted the update-area-descriptions branch November 29, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor issues with area-related parameters
2 participants