-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cost expression names & split out expressions #685
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #685 +/- ##
=======================================
Coverage 95.95% 95.95%
=======================================
Files 29 29
Lines 4025 4026 +1
Branches 845 775 -70
=======================================
+ Hits 3862 3863 +1
Misses 72 72
Partials 91 91
|
@sstroemer can you check that this is what you were thinking w.r.t. updating expressions? |
@brynpickering Looks really good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, much clearer than before!
Fixes #645
The only thing I have chosen to not implement from #645 is
cost_investment
->cost_investment_total
. I'm not sure that_total
adds anything...Summary of changes in this pull request
cost_investment
cost_investment_annualised
cost_operation_fixed
cost_operation_variable
cost
is the sum ofcost_investment_annualised
,cost_operation_fixed
, andcost_operation_variable
.Reviewer checklist