Expose functions to force the polyfill and make not exception with WC polyfill #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdwilliams
approved these changes
Dec 21, 2023
|
This has been released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expose the
forceCustomStateSetPolyfill()andforceElementInternalsPolyfill()functions as well as make the polyfill not exception when the Custom Elements and or the Shady DOM Polyfill is also applied. NOTE: with these polyfills, the EI polyfill will not work as intended, but it enables custom elements using ElementInternals from exceptioning in these cases.The main use case for this is for consuming WCs that use ElementInternals Chrome extensions. Content Scripts in Chrome extensions (until we have scoped custom elements) require you use the CE polyfill. WCs that have ElementInternals will exception because they are being applied to non-custom elements. This polyfill will not help because it does feature detection and chrome has EI. Therefore we need EI polyfill to be forced.