Skip to content

Commit

Permalink
fix unhelpful log message with wrong MSVS version
Browse files Browse the repository at this point in the history
Closes paixaop#147

Right now it would crash with this error, instead of returning the helpful message about setting msvs to a different version.

```javascript
    console.log('Invalid msvs_version ' + msvsVersion + '\n');
                                          ^

ReferenceError: msvsVersion is not defined
```
  • Loading branch information
jabbink authored Mar 12, 2019
1 parent 5117314 commit 2b130af
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions install.js
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ function errorSetMSVSVersion() {
}

function errorInvalidMSVSVersion() {
console.log('Invalid msvs_version ' + msvsVersion + '\n');
console.log('Invalid msvs_version ' + process.env.npm_config_msvs_version + '\n');
console.log('Please set your Microsoft Visual Studio version before you run npm install');
console.log('Example for Visual Studio 2015:\n');
console.log(' For you user only:\n');
Expand Down Expand Up @@ -371,4 +371,4 @@ if (os.platform() !== 'win32') {
});
});
}
}
}

0 comments on commit 2b130af

Please sign in to comment.