Merge pull request #322 from cakephp/fix-seed-task

Fix baking a seed class

.travis.yml

@@ -76,7 +76,7 @@ before_script:
 
 script:
   - sh -c "if [ '$DEFAULT' = '1' ]; then vendor/bin/phpunit --stderr; fi"
-  - sh -c "if [ '$PHPSTAN' = '1' ]; then composer require --dev phpstan/phpstan:^0.6 && vendor/bin/phpstan analyse -c phpstan.neon -l 1 src; fi"
+  - sh -c "if [ '$PHPSTAN' = '1' ]; then composer require --dev phpstan/phpstan:^0.8 && vendor/bin/phpstan analyse -c phpstan.neon -l 1 src; fi"
   - sh -c "if [ '$CODECOVERAGE' = '1' ]; then phpdbg -qrr vendor/bin/phpunit --coverage-clover=clover.xml || true; fi"
   - sh -c "if [ '$CODECOVERAGE' = '1' ]; then wget -O codecov.sh https://codecov.io/bash; fi"
   - sh -c "if [ '$CODECOVERAGE' = '1' ]; then bash codecov.sh; fi"

phpstan.neon

@@ -2,4 +2,6 @@ services:
     -
         class: Migrations\PHPStan\ShellPropertiesClassReflectionExtension
         tags:
-            - phpstan.broker.propertiesClassReflectionExtension
+            - phpstan.broker.propertiesClassReflectionExtension
+parameters:
+    bootstrap: tests/PHPStan/bootstrap.phpstan.php

src/Shell/Task/SeedTask.php

@@ -22,6 +22,8 @@
 
 /**
  * Task class for generating seed files.
+ *
+ * @property \Bake\Shell\Task\BakeTemplateTask
  */
 class SeedTask extends SimpleBakeTask
 {
@@ -32,13 +34,6 @@ class SeedTask extends SimpleBakeTask
      */
     public $pathFragment = 'config/Seeds/';
 
-    /**
-     * BakeTemplate instance.
-     *
-     * @var \Bake\Shell\Task\BakeTemplateTask
-     */
-    public $BakeTemplate;
-
     /**
      * {@inheritDoc}
      */

tests/PHPStan/BakeTemplatePropertyReflection.php

@@ -44,4 +44,14 @@ public function getType(): Type
     {
         return $this->type;
     }
+
+    public function isReadable(): bool
+    {
+        return true;
+    }
+
+    public function isWritable(): bool
+    {
+        return true;
+    }
 }

tests/PHPStan/bootstrap.phpstan.php

@@ -0,0 +1,16 @@
+<?php
+/**
+ * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
+ * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+ *
+ * Licensed under The MIT License
+ * For full copyright and license information, please see the LICENSE.txt
+ * Redistributions of files must retain the above copyright notice.
+ *
+ * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+ * @link          http://cakephp.org CakePHP(tm) Project
+ * @license       http://www.opensource.org/licenses/mit-license.php MIT License
+ */
+define('ROOT', '');
+define('APP', 'app');
+define('PHINX_VERSION', '0.8.1');