Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DotNetAddPackage alias for dotnet add package command #4195

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Add DotNetAddPackage alias for dotnet add package command #4195

merged 5 commits into from
Oct 10, 2023

Conversation

Marusyk
Copy link
Contributor

@Marusyk Marusyk commented Jul 19, 2023 •
edited
Loading

Add an alias for dotnet add package command

Fixes #4187

Please review
Thank you in advance

@Marusyk Marusyk marked this pull request as ready for review July 19, 2023 08:48
devlead
devlead requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add an integration test here to
https://github.com/cake-build/cake/blob/6be615392ac27b52d979b5284993f84f175c7201/tests/integration/Cake.Common/Tools/DotNet/DotNetAliases.cake

Could use XmlPeek to verify package added, similar to

cake/tests/integration/Cake.Common/Tools/NuGet/NuGetAliases.cake

Line 94 in 6be6153

var value = XmlPeek(

@Marusyk
Copy link
Contributor Author

Marusyk commented Oct 10, 2023

changed the package in the las commit because it doesn't work for Cake.FileHelper

@Marusyk Marusyk requested a review from devlead October 10, 2023 19:29
devlead
devlead approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 27a28a5 into cake-build:develop Oct 10, 2023
6 checks passed
@devlead
Copy link
Member

devlead commented Oct 10, 2023

@Marusyk your changes have been merged, thanks for your contribution 👍

@Marusyk Marusyk deleted the rmarusyk/4187 branch October 10, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DotNetAddPackage alias for dotnet add package command
2 participants
@Marusyk @devlead