Update Models with gfactor Speed #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clearinghouse__detector_agg_five_minutes_with_missing_rows to int_clearinghouse__detector_agg_five_minutes model. In the int_clearinghouse__detector_agg_five_minutes_with_missing_rows model add the g-factor speed data to detectors/timestamps where speed is not being provided by the field devices In the int_imputation__detector_agg_five_minutes and int_performance__detector_metrics_agg_five_minutes models remove the old speed calculation formula and notes. YAML file updated describing the speed value being used in the int_clearinghouse__detector_agg_five_minutes_with_missing_rows model.
JamesSLogan
reviewed
Dec 19, 2024
| left join gfactor_speed as gs | ||
| on | ||
| agg.detector_id = gs.detector_id | ||
| and agg.sample_timestamp = gs.sample_timestamp |
There was a problem hiding this comment.
Note: adding another join to this already expensive model doesn't seems to hurt performance too much (see query profile from CI here), but let's keep our eyes on it.
There was a problem hiding this comment.
The other alternatives we could investigate are creating a new model downstream of int_clearinghouse__detector_agg_five_minutes_with_missing_rows to add the g-factor speed or possibly add it to the int_imputation__detector_agg_five_minutes model.
…g_five_minutes model since it is no longer applicable. All speed values are being added in the clearinghouse and imputation models upstream of the int_performance__detector_metrics_agg_five_minutes model. If the is_speed_calculated column is needed, it can be added to the clearinghouse models.
thehanggit
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Thank you @kengodleskidot. I think @JamesSLogan made a good point. Other than that, everything looks good. Let's have our own g-factor speed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
Resolves #484