Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest major version of dbt-core and dbt-snowflake #487

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

summer-mothwood
Copy link
Contributor

Need to be on 1.8 to set/test the new flags in Dev. Is this all I need to do in the code to trigger this update (in addition to setting the version in the environment)?

@ian-r-rose
Copy link
Member

You also need to update the poetry.lock as part of the process. Taking a closer look, I think I might have also made a mistake with the previous version specifier (I think we want ~1.8 rather than ~1.8.0)

So a single command to update both the pyproject.toml and the poetry.lock would be:

poetry add "dbt-core@~1.8" "@dbt-snowflake@~1.8"

Of course, if we adopt uv instead of poetry, it would be a different (but similar!) command

@summer-mothwood
Copy link
Contributor Author

@ian-r-rose I ended up doing the following:

  • manually changed the versions of the dbt-core and dbt-snowflake packages to ~1.8 in pyproject.toml
  • ran poetry lock locally on this branch to update the poetry lock file
  • staged and committed the poetry lock file changes

If that all looks right, I'll add these instructions to our docs as well.

I couldn't get poetry add "dbt-core@~1.8" "@dbt-snowflake@~1.8" to run on a clean branch, as I kept getting an error on the dbt-snowflake package:
image

@ian-r-rose
Copy link
Member

Whoops, just a typo in that I added an extra @ symbol in my comment above. Your changes look good to me!

@summer-mothwood summer-mothwood merged commit cc75358 into main Nov 26, 2024
2 of 3 checks passed
@summer-mothwood summer-mothwood deleted the summer-versionless-config branch November 26, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants