Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attempts badge #749

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Add attempts badge #749

merged 2 commits into from
Dec 2, 2024

Conversation

Assem-Hafez
Copy link
Contributor

@Assem-Hafez Assem-Hafez commented Nov 29, 2024 •
edited
Loading

Summary

Lifting up the attempts count in the history timeline so it is easier for users to find retrying events.

Changes

  • Add attempt count badge in both compact and expandable timeline.
  • Remove timestamp from the compact view to save space for more useful information.
  • Showing (maximumAttempts | expirationIntervalInSeconds) ===0 as Not set

Screenshots

Attempts badge
Screenshot 2024-11-29 at 11 24 48

Showing 0 expirationIntervalInSeconds as not set
Screenshot 2024-11-29 at 12 02 30

@adhityamamallan adhityamamallan merged commit 7412bd2 into cadence-workflow:release/4.0.0 Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhityamamallan adhityamamallan adhityamamallan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Assem-Hafez @adhityamamallan