Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch domain workflows when a query is provided #742

Conversation

adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Nov 25, 2024

Summary

  • Use inputType query param to decide the params to send to ListWorkflows API
  • Modify useListWorkflows to use query params directly, instead of passing them as props
  • Modify error panel helper to return special errors for query mode
  • Use useListWorkflows hook in header to allow query refetching
  • Remove as const satisfies ... from domain workflows table config since we modify it to get the query table config

Test plan

Unit tests updated + ran locally.

@adhityamamallan adhityamamallan changed the title Make call to send query Fetch domain workflows when a query is provided Nov 25, 2024
@adhityamamallan adhityamamallan marked this pull request as ready for review November 25, 2024 10:09
@Assem-Uber Assem-Uber merged commit 599b170 into cadence-workflow:release/4.0.0 Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants