Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use format input in activity scheduled event #735

Conversation

Assem-Hafez
Copy link
Contributor

Summary

Use our default input parser to parse the input of the activity since it follows same multi argument input we have for workflow. This function helps parsing all activity arguments as json instead of treating json strings arguments as strings.

Changes

  • Rename the parsing function from formatWorkflowInputPayload to formatInputPayload as it no longer works for workflow only but activity also
  • use the parsing function with the activity scheduled event
  • update unit test snapshot to match the new parsing types (numbers where parsed as strings incorrectly)
  • while updating the snapshot i notice that the new value precision is not correct... going to address this in the next PR

Screenshots

Before:
Screenshot 2024-11-21 at 13 55 38
After:
Screenshot 2024-11-21 at 13 59 17

@Assem-Uber Assem-Uber merged commit e4e4d88 into cadence-workflow:release/4.0.0 Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants