Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Query view to Domain Workflows page #734

Conversation

adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Nov 21, 2024

Summary

Page Filters

  • Separate Page Filters search bar into a dedicated component

List Workflows Route Handler

  • Add query params inputType and query
  • Return empty response by default if inputType is query but no query is sent

Domain Workflows

  • Add query params inputType and query
  • Separate ListWorkflows logic into dedicated React hook
  • Move Domain Workflows page size into config

Domain Workflows Filters -> Header

  • Rename Domain Workflows Filters to Header
  • Add SegmentedControl to switch between Search and Query
  • Add Query Input and Run button for Query view
  • Add Query Label component with configurable Tooltip
  • Add Tooltip config

Domain Workflows Table

  • Separate Domain Workflows table into two paths, one for Search and one for Query
  • Both of these are similar, except the Query view has modifications made to:
    • request query params
    • error panel logic
    • "sortable" flag in table config
    • sort params
  • Add an end case "No workflows" to unit tests

Test plan

Unit tests + ran cadence-web locally.

Screenshot 2024-11-21 at 6 06 53 PM Screenshot 2024-11-21 at 6 07 06 PM Screenshot 2024-11-21 at 6 09 04 PM Screenshot 2024-11-21 at 6 10 17 PM

@adhityamamallan adhityamamallan changed the title Domain queries Add Query view to Domain Workflows page Nov 21, 2024
@adhityamamallan adhityamamallan marked this pull request as ready for review November 21, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant