Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace query params by default in Page Filters #730

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Replace query params by default in Page Filters #730

merged 1 commit into from
Nov 19, 2024

Conversation

adhityamamallan
Copy link
Member

Summary

  • Configure usePageQueryParams in usePageFilters hook to replace query params in history by default
  • Fix usePageQueryParams setter impl to honour setterExtraConfig over usePageQueryParams extra config

Test plan

Ran locally and verified that history gets replaced

@Assem-Uber Assem-Uber merged commit 0dfecd9 into cadence-workflow:release/4.0.0 Nov 19, 2024
1 check passed
@adhityamamallan adhityamamallan deleted the query-params-replace branch November 19, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Assem-Uber Assem-Uber Assem-Uber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhityamamallan @Assem-Uber