-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli command modal #727
Add cli command modal #727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- How do we want to make these commands configurable in the future?
- If we want to show the commands on a different page, would it be possible to configure these commands to show there too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: fix the file name (*copy-text-button)
@@ -17,6 +18,7 @@ export default function PageTabs({ | |||
setSelectedTab(activeKey); | |||
}} | |||
overrides={overrides.tabs} | |||
endEnhancer={endEnhancer} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call this prop something else? Because individual tabs also have end enhancers, and it can get confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cant think of a name that would make it less confusing tabsEndEnhancer
? It still confusing.
Update:
Not the most clear but it is still distinguishable as all individual tabs are configured though the tabs array
1- These commands are already configurable. We have configuration files for tabs and commands that can be replaced. |
Sorry, my bad. My question was: how can we prepopulate params in these commands in the future? |
We can use string interpolation. |
Summary
Add a modal to show most important cli commands. The commands are grouped into two tabs domain & workflow
Changes
endEnhancer
Screenshots