Skip to content

Commit

Permalink
Feature/fix cron filter advanced visibility disabled (#350)
Browse files Browse the repository at this point in the history
* fixed whitespace issue when advanced visibility is disabled for the cluster.

* changing prop type for feature flag grow to allow string

* fixing test by increasing delay time.

* adding delay to test after the modal is opened before checking text.
  • Loading branch information
just-at-uber authored Jun 9, 2021
1 parent 1977945 commit 97610a2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion client/components/feature-flag.vue
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export default {
validator: value => ['inline', 'inline-block'].includes(value),
},
grow: {
type: Number,
type: [String, Number],
},
margin: {
type: String,
Expand Down
2 changes: 1 addition & 1 deletion client/containers/workflow-list/component.vue
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,7 @@ export default {
grow="1"
margin="5px"
name="workflowListIsCron"
v-if="isCronInputVisible"
width="115px"
>
<select-input
Expand All @@ -482,7 +483,6 @@ export default {
:options="isCronList"
:value="isCron"
@change="onIsCronChange"
v-if="isCronInputVisible"
/>
</feature-flag>
<flex-grid-item grow="1" width="105px">
Expand Down
2 changes: 2 additions & 0 deletions client/test/workflow.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,8 @@ describe('Workflow', () => {
'[data-modal="confirm-termination"]'
);

await Promise.delay(50);

confirmTerminateEl.should.contain.text(
'Are you sure you want to terminate this workflow?'
);
Expand Down

0 comments on commit 97610a2

Please sign in to comment.