Fix bug in Cadence Web where falsy values do not render correctly

cadence-workflow · Nov 15, 2023 · 62495a6 · 62495a6
1 parent fcf7b34
commit 62495a6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/client/helpers/get-json-string-object.js b/client/helpers/get-json-string-object.js
@@ -22,8 +22,8 @@
 import getStringElipsis from './get-string-elipsis';
 
 const getJsonStringObject = value => {
-  const jsonStringFull = value ? JSON.stringify(value, null, 2) : '';
-  const jsonStringDisplay = value ? getStringElipsis(jsonStringFull) : '';
+  const jsonStringFull = value !== null && value !== undefined ? JSON.stringify(value, null, 2) : '';
+  const jsonStringDisplay = getStringElipsis(jsonStringFull);
 
   return {
     jsonStringDisplay,

diff --git a/client/helpers/get-string-elipsis.spec.js b/client/helpers/get-string-elipsis.spec.js
@@ -31,6 +31,14 @@ describe('getStringElipsis', () => {
       expect(output).toEqual('a-short-string');
     });
   });
+  describe('when passed the empty string', () => {
+    it('should return the empty string', () => {
+      const input = '';
+      const output = getStringElipsis(input);
+
+      expect(output).toEqual('');
+    });
+  });
   describe('when passed a string that has a length equal to MAXIMUM_JSON_CHARACTER_LIMIT', () => {
     it('should return a substring of the original string up until the limit and display a message.', () => {
       const input = ''.padEnd(MAXIMUM_JSON_CHARACTER_LIMIT, '_');