Minor race prevention: do not mutate callers' retry policy #1413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Description
Concurrently calling
workflow.WithActivityOptions
with a shared retry policy instance that does not set a backoff coefficient can trigger a race because this function mutated it unnecessarily.The fix is easy: just don't do that :)
Impact Analysis
Fixes tests and prod that share activity-option-vars, which is somewhat common in some codebases. I'm not sure if this can lead to any actual misbehavior since it's a single-word value and it's only ever adjusted to one other value, but I'm fully on board with "never allow races no matter what".
Testing Plan
Test suite should be plenty.
Rollout Plan
Nothing special.