Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poller auto scaler rework #1409

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

shijiesheng
Copy link
Member

What changed?

  • removed autoscaler package; it's no longer used after the rework
  • Used poller wait time from autoConfigHint field for poller scaling
  • Scaling now happens every 1s with a sustained cooldown time instead of periodically 1 min change to react to traffic change quicker

Why?

How did you test it?

Potential risks


// Permit is an adaptive permit issuer to control concurrency
type Permit interface {
Acquire(context.Context) error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind adding comments for each method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants