Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cadence/debug] Update polletracker to support poller type breakdown #1406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ketsiambaku
Copy link
Contributor

@ketsiambaku ketsiambaku commented Dec 2, 2024

What changed?
We use the PollerTracker interface to count the number of running pollers and we display it internal in a debug page.
This change is updating the interface and its usage so that the poller count is broken down by worker type (e.g: activity, workflow, shadow, localactivity, etc.)

Why?
The break down gives a better insight on the running instance

How did you test it?
unit tests

Potential risks

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.52%. Comparing base (e3802b7) to head (65fdc1b).
Report is 1 commits behind head on master.

Files with missing lines Coverage Δ
internal/common/debug/workerstats_noop.go 100.00% <100.00%> (ø)
internal/internal_worker_base.go 83.41% <100.00%> (+1.46%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3802b7...65fdc1b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant