fix: let devenv-created OCI images be compatible with libnvidia-container
#873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atry
changed the title
Currently containers created by `devenv` will contain a symlink `/lib -> /nix/store/lf0wpjrj8yx4gsmw2s3xfl58ixmqk8qa-bash-5.2-p15/lib`. The symlink conflicts with `libnvidia-container` because `libnvidia-container` tries to create a file `/lib/firmware/nvidia/525.85.12/gsp_ad10x.bin` while it specifies `O_NOFOLLOW` according to https://github.com/NVIDIA/libnvidia-container/blob/1eb5a30a6ad0415550a9df632ac8832bf7e2bbba/src/utils.c#L523 This PR makes `/lib` a regular directory, while making files under `/lib` symlinks so that it would be compatible with `libnvidia-container`.
Atry
changed the title
devenv created OCI images be compatible with libnvidia-container
Atry
changed the title
devenv created OCI images be compatible with libnvidia-containerdevenv created OCI images be compatible with libnvidia-container
Atry
changed the title
devenv created OCI images be compatible with libnvidia-containerdevenv-created OCI images be compatible with libnvidia-container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently OCI images created by
devenvcontain a symlink/lib -> /nix/store/lf0wpjrj8yx4gsmw2s3xfl58ixmqk8qa-bash-5.2-p15/lib. The symlink conflicts withlibnvidia-containerbecauselibnvidia-containertries to create a file/lib/firmware/nvidia/525.85.12/gsp_ad10x.binwhile it specifiesO_NOFOLLOWaccording to https://github.com/NVIDIA/libnvidia-container/blob/1eb5a30a6ad0415550a9df632ac8832bf7e2bbba/src/utils.c#L523As a result,
libnvidia-containerwill produce the following error when starting a container built fromdevenvThis PR makes
/liba regular directory, and makes files under/libsymlinks, so that the OCI images created bydevenvwould be compatible withlibnvidia-container.