feat: adds support for multiple IP configurations for one hostname in hostctl.nix
#858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @domenkozar as agreed in a previous Discord conversation. 👍 |
rmachado-studocu
changed the title
hostctl.nixhostctl.nix
|
I'd appreciate if you can add an example to https://github.com/cachix/devenv/blob/main/examples/mkcert/devenv.nix so that at least we know Nix evaluates. |
|
You need to run |
|
@domenkozar I've run pre-commit and pushed the changes 👍 Thanks! |
rmachado-studocu
deleted the
add-support-for-multiple-ips-for-one-hostname
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
127.0.0.1and::1to be the resolution for the same hostname (e.gexample.com).I'd highlight that this PR adds support for multiple IPs (as a list of strings) but it also supports the original approach of having just a string.
In OSes like MacOS, where local dns resolution requires both configurations (otherwise you get a 10s delay on it), this is quite important for performance.
It's my first time coding in Nix language so, please bear with my poor coding skills on it. 😄
Thank you for your time reviewing my PR and for allowing me to learn with your expertise.
Closes #857