Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devenv: skip the cache warning if the requested substituters are already configured #1610

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

sandydoo
Copy link
Member

@sandydoo sandydoo commented Nov 24, 2024

If devenv cannot configure the requested caches, it displays instructions to either become a trusted user or to set up the caches globally. However, it never checks if the caches are actually configured, so the only solution is to set cachix.enable = false;, which can get tedious across many projects.

This PR queries Nix to figure out which caches and keys are missing. If the user is not trusted, but all the caches are already configured, no warning is shown.

@sandydoo sandydoo marked this pull request as draft November 24, 2024 15:34
@sandydoo sandydoo added enhancement New feature or request cli Related to the devenv CLI labels Nov 24, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 24, 2024

Deploying devenv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8056ceb
Status: ✅  Deploy successful!
Preview URL: https://fe5b3a58.devenv.pages.dev
Branch Preview URL: https://detect-caches.devenv.pages.dev

View logs

@sandydoo sandydoo marked this pull request as ready for review November 25, 2024 13:51
@sandydoo sandydoo requested a review from domenkozar November 25, 2024 13:52
@domenkozar domenkozar merged commit 7a105e8 into main Nov 28, 2024
261 of 277 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the devenv CLI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants