package: use binary wrapper and preset locale archive #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also needs to go to nixpkgs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On non-NixOS Linux systems, any call to bash will print out a warning about failing to set locale vars. This can be triggered for the entire code path, from launching devenv until
enterShell.The fix is to set
LOCALE_ARCHIVEglobally. This should be done right after installing Nix, but is not a very obvious thing.The issue with devenv is that our first entry-point is
wrapProgram, which calls bash. This PR switches tomakeBinaryWrapperto avoid calls to bash and setsLOCALE_ARCHIVEif missing.