Update isValid method to match the bson node library #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bson node library recently updated the `ObjectID.isValid` method. This PR updates the method to match those changes. The bson library method can be seen here, at line 293: https://github.com/mongodb/js-bson/blob/master/src/objectid.ts
Fixed Typo.
|
Does this also fix #39 and #45? Can we add tests? @MrEmanuel |
|
Let me know @MrEmanuel |
This was referenced Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bson node library recently updated the
ObjectID.isValidmethod.This PR updates the method to match those changes.
The bson library method can be seen here, at line 293: https://github.com/mongodb/js-bson/blob/master/src/objectid.ts