Merge pull request #47 from rparet/fix_timestamp_type

fixed type on getTimestamp()
cabinjs · Mar 12, 2022 · d1520df · d1520df
2 parents 5006541 + b6efcc6
commit d1520df
Show file tree

Hide file tree

Showing 4 changed files with 293 additions and 20 deletions.
diff --git a/objectid.d.ts b/objectid.d.ts
@@ -10,7 +10,7 @@ declare interface ObjectID {
 
   toHexString(): string;
   equals(other: ObjectID): boolean;
-  getTimestamp(): number;
+  getTimestamp(): Date;
 }
 
 declare interface ObjectIDCtor {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -31,8 +31,8 @@
   "homepage": "https://github.com/williamkapke/bson-objectid",
   "devDependencies": {
     "@types/node": "^8.0.31",
+    "mocha": "^5.2.0",
     "should": "^4.1.0",
-    "typescript": "^2.5.3",
-    "mocha": "^5.2.0"
+    "typescript": "^4.6.2"
   }
 }
diff --git a/typing-tests/objectid-tests.ts b/typing-tests/objectid-tests.ts
@@ -84,7 +84,7 @@ oid = ObjectID(idString);
 
 // ----------------------------------------------------------------------------
 // should correctly retrieve timestamp
-const timestamp:number = oid.getTimestamp();
+const timestamp:Date = oid.getTimestamp();
 
 // ----------------------------------------------------------------------------
 // should validate valid hex strings