v8 #336
Open
v8 #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"In Electron 12, contextIsolation will be enabled by default. To restore the previous behavior, contextIsolation: false must be specified in WebPreferences." "Another implication is that require() cannot be used in the renderer process unless nodeIntegration is true and contextIsolation is false." https://github.com/electron/electron/blob/main/docs/breaking-changes.md#default-changed-contextisolation-defaults-to-true
"Fix compatibility with Electron 12 (and remove use of electron.remote)" https://github.com/sindresorhus/electron-store/releases/tag/v7.0.0
"In Electron 9, using the remote module without explicitly enabling it via the enableRemoteModule WebPreferences option began emitting a warning. In Electron 10, the remote module is now disabled by default. To use the remote module, enableRemoteModule: true must be specified in WebPreferences:" https://github.com/electron/electron/blob/main/docs/breaking-changes.md#default-changed-enableremotemodule-defaults-to-false if migrating to larger versions, in particular for electron-store@2 see the following links https://stackoverflow.com/questions/55850616/uncaught-referenceerror-module-is-not-defined-on-delete-module-exports electron/remote#79 https://github.com/electron/remote/blob/main/docs/migration-2.md
migrated according to the migration guide: https://github.com/electron/remote/blob/main/docs/migration-2.md "To migrate from @electron/[email protected] to @electron/[email protected], replace all usages of the enableRemoteModule: true WebPreference by a call to enable()." ``` // Before (@electron/[email protected]) const win = new BrowserWindow({ webPreferences: { enableRemoteModule: true } }) // After (@electron/[email protected]) const remoteMain = require("@electron/remote/main") remoteMain.initialize() const win = new BrowserWindow() remoteMain.enable(win.webContents) ```
more thanks to internet slouths & strangers: https://stackoverflow.com/questions/36637201/requiring-electron-dialog-from-render-process-is-undefined
also swap out `node-sass` for `sass` library to fix the build
|
It'll be great to have this merged into master and have that cabal-client fix go live -- thanks Nick! 🖤 |
hackergrrl
approved these changes
Feb 21, 2024
|
Oh, @nikolaiwarner do you know how to get notorization working again? |
cblgh
reviewed
Feb 29, 2024
Comment on lines
+6
to
+7
| #- linux | ||
| #- windows |
There was a problem hiding this comment.
Suggested change
| #- linux | |
| #- windows | |
| - linux | |
| - windows |
There was a problem hiding this comment.
these were turned off 'cause we were focusing on debugging OSX builds :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi! i bumped cabal-client to the latest. ok if we merge all of this branch and then i'll make a release?