Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix # Issue with gene-panel-data/fetch API When molecularProfileIds is Empty [Issue 11252] #11253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonkiky
Copy link

@jonkiky jonkiky commented Dec 4, 2024

Fix # Issue with gene-panel-data/fetch API When molecularProfileIds is Empty
Related issue ticket: #11252

There is an issue when using the API gene-panel-data/fetch with an empty molecularProfileIds array as the request payload, it returns error.

Describe changes proposed in this pull request:

  • The fix allows to pass in empty molecularProfileIds and response empty list .

@Aiosa
Copy link

Aiosa commented Dec 10, 2024

I did similar thing to fix the checker:

BBMRI-ERIC/cbioportal@8636b4a#diff-1054b9ebb643fc3312ccec2bec08d82d9e28f9249024817405fd16ded9023a5fR93

However, I had to also extend endpoint to allow query to request 0 identifiers

BBMRI-ERIC/cbioportal@8636b4a#diff-1054b9ebb643fc3312ccec2bec08d82d9e28f9249024817405fd16ded9023a5fR93

Note that github seems to be having issue with direct links to rows, so you might need to search for relevant lines in the GenePanelDataMultipleStudyFilter.java and GenePanelDataController.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants