Fix failing integration tests #11246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onursumer
force-pushed
the
increase-response-timeout
branch
5 times, most recently
from
d050f91 to
9b580f7
Compare
onursumer
force-pushed
the
increase-response-timeout
branch
2 times, most recently
from
823c2ae to
c1d0517
Compare
|
onursumer
commented
Dec 4, 2024
Comment on lines
+48
to
+51
| sed 'a spring.datasource.driver-class-name=com.mysql.jdbc.Driver' | \ | ||
| sed 'a spring.datasource.url=jdbc:mysql://cbioportal-database:3306/cbioportal?useSSL=false' | \ | ||
| sed 'a spring.datasource.username=cbio_user' | \ | ||
| sed 'a spring.datasource.password=somepassword' \ |
There was a problem hiding this comment.
This is a workaround to add legacy properties which are needed by migrate.py script. This is required for now because migration script is in the separate cbioportal-core repo.
|
#11256 fixes the integration tests, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing parameters for DB connection and the migration script