Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10789 Modified EFGR values for Mutations in Download tab #5057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arishta-dev
Copy link

@arishta-dev arishta-dev commented Nov 28, 2024

Fixes cBioPortal/cbioportal#10789

Describe changes proposed in this pull request:

  • Changed mutation data download format to display 'NP' instead of 'NS' for non-sequenced samples
  • Updated generateMutationDownloadData function in DownloadUtils.ts to use 'NP' as the default value for non-sequenced samples

Here is a before and after screenshot of the file.

Screenshot 2024-11-28 at 11 13 43 AM

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 1da7f78
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/674a89b387171800083eca8d
😎 Deploy Preview https://deploy-preview-5057.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arishta-dev
Copy link
Author

Hi @inodb
Please review this PR, it solves this issue: cBioPortal/cbioportal#10789

@arishta-dev arishta-dev changed the title Modified EFGR values for Mutations in Download tab #10789 Modified EFGR values for Mutations in Download tab Nov 29, 2024
@arishta-dev arishta-dev force-pushed the update-mutations-tab-ESGR-column branch from e17d70c to 1da7f78 Compare November 30, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use NP consistently in download tab
1 participant