Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10932 Add gene column in the Mutations table #5049

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arishta-dev
Copy link

@arishta-dev arishta-dev commented Nov 23, 2024

Fixes cBioPortal/cbioportal#10932

Summary:

  • Added gene column to the Mutation table

Detailed summary of the change:

-> The GeneColumnFormatter was already implemented in the codebase, so simply added MutationTableColumnType.GENE to the default columns array in ResultsViewMutationTable.tsx. This makes the gene information visible in the mutation table. Also this column will only visible in the tsv file, not in the UI.

Screenshot:

Here is a screenshot showing Before and After state of the mutation table.

Screenshot 2024-11-23 at 5 03 49 PM

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit dc1480f
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/674a895350de77000847c7db
😎 Deploy Preview https://deploy-preview-5049.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arishta-dev
Copy link
Author

Hi @jjgao @inodb Please review this PR, or let me know who to ask for review .
I see a bunch of tests failing, but seems like they are not related to the PR, as I see the same tests failing for other PRs as well.

@inodb
Copy link
Member

inodb commented Nov 24, 2024

@arishta-dev Thanks so much for working on this! Could you change the logic to only add the column when downloading the file rather than always showing it? Ideally we wouldn't see it in the UI. The user already knows they're looking at CDKN2A in the browser, but we want to make sure it's clear in the downloaded file too

@arishta-dev
Copy link
Author

hi @inodb Thanks for your suggestion - I have modified the code, now gene column will only show in the tsv file.

@arishta-dev arishta-dev changed the title Add gene column in the Mutations table #10932 Add gene column in the Mutations table Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mutations tab] add gene column to downloaded file from mutations table
2 participants