-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce api calls for generic assay meta in study view page #5019
Open
dippindots
wants to merge
44
commits into
cBioPortal:clickhouse
Choose a base branch
from
dippindots:generic-assay-meta-study-view-reduce-call
base: clickhouse
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reduce api calls for generic assay meta in study view page #5019
dippindots
wants to merge
44
commits into
cBioPortal:clickhouse
from
dippindots:generic-assay-meta-study-view-reduce-call
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust patient treatments and sample treatments to use new treatment-counts api endoint (clickhouse driven)
* Add rfc80 test generator UI and test runner
* fix production build after webpack.config changes
* fix has generation based on url * add back all endpoints
…ta bin counts filters (cBioPortal#4980)
…#4981) * add tests for sample lists counts and custom data filters * add tests for custom data bin counts --------- Co-authored-by: Bryan Lai <[email protected]>
* improvements to apiTests reporting * add skips to validation, refine report * skip test * improve report * Move api e2e to backend
…n fails on label fields
* use original clickhouse request. don't repeat it * Add generic assay endpoints and disable cn segments tab
… on command line, fx treatment validation
* add assertResponse capability to clickhouse validator * fixed reporting for custom data
❌ Deploy Preview for cbioportalfrontend failed. Why did it fail? →
|
dippindots
commented
Oct 11, 2024
this.genericAssayProfiles.result | ||
); | ||
}, | ||
}); | ||
|
||
readonly genericAssayStableIdToMeta = remoteData<{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reference, deleting this function
dippindots
force-pushed
the
generic-assay-meta-study-view-reduce-call
branch
3 times, most recently
from
October 15, 2024 06:11
b7d4fa5
to
2b27301
Compare
* add runner for validation of datadog logged traffic * use axios for validation ajax to normalize * get rid of specs
dippindots
force-pushed
the
generic-assay-meta-study-view-reduce-call
branch
from
October 17, 2024 16:49
2b27301
to
73f2ebe
Compare
alisman
force-pushed
the
clickhouse
branch
2 times, most recently
from
November 25, 2024 19:34
ecba99f
to
22501dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.